From: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
Date: Tue, 30 May 2023 09:27:55 +0000 (+0800)
Subject: gh-102251: Fix reference leak in _testsinglephase initialization (#105082)
X-Git-Tag: v3.13.0a1~1980
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d14eb3433cf2a40a202471b815f0a935f2840ead;p=thirdparty%2FPython%2Fcpython.git

gh-102251: Fix reference leak in _testsinglephase initialization (#105082)

Correctly decref 'initialized' in init_module()

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
---

diff --git a/Modules/_testsinglephase.c b/Modules/_testsinglephase.c
index a16157702ae7..8e6973f0b052 100644
--- a/Modules/_testsinglephase.c
+++ b/Modules/_testsinglephase.c
@@ -140,7 +140,9 @@ init_module(PyObject *module, module_state *state)
     if (initialized == NULL) {
         return -1;
     }
-    if (PyModule_AddObjectRef(module, "_module_initialized", initialized) != 0) {
+    int rc = PyModule_AddObjectRef(module, "_module_initialized", initialized);
+    Py_DECREF(initialized);
+    if (rc < 0) {
         return -1;
     }