From: Zackery Spytz <zspytz@gmail.com>
Date: Tue, 27 Nov 2018 05:40:49 +0000 (-0700)
Subject: Include the highest pickle protocol in a couple of tests. (GH-10735)
X-Git-Tag: v3.8.0a1~412
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d1cbc6f8a00cf881ced6238c5e652054e8fdc30f;p=thirdparty%2FPython%2Fcpython.git

Include the highest pickle protocol in a couple of tests. (GH-10735)

test_reduce_ex() in test_array.py and
test_reversevaluesiterator_pickling() in test_dict.py weren't using
the highest pickle protocol.
---

diff --git a/Lib/test/test_array.py b/Lib/test/test_array.py
index e9218f3dd68c..7f402f864471 100644
--- a/Lib/test/test_array.py
+++ b/Lib/test/test_array.py
@@ -248,7 +248,7 @@ class BaseTest:
         a = array.array(self.typecode, self.example)
         for protocol in range(3):
             self.assertIs(a.__reduce_ex__(protocol)[0], array.array)
-        for protocol in range(3, pickle.HIGHEST_PROTOCOL):
+        for protocol in range(3, pickle.HIGHEST_PROTOCOL + 1):
             self.assertIs(a.__reduce_ex__(protocol)[0], array_reconstructor)
 
     def test_pickle(self):
diff --git a/Lib/test/test_dict.py b/Lib/test/test_dict.py
index 71fffe398f34..03afd5b2a6c7 100644
--- a/Lib/test/test_dict.py
+++ b/Lib/test/test_dict.py
@@ -1112,7 +1112,7 @@ class DictTest(unittest.TestCase):
             self.assertEqual(dict(it), data)
 
     def test_reversevaluesiterator_pickling(self):
-        for proto in range(pickle.HIGHEST_PROTOCOL):
+        for proto in range(pickle.HIGHEST_PROTOCOL + 1):
             data = {1:"a", 2:"b", 3:"c"}
             # data.values() isn't picklable, only its iterator
             it = reversed(data.values())