From: Steven Murdoch Date: Tue, 30 Aug 2011 14:02:28 +0000 (+0100) Subject: Document limitation of log_from_handle with partial reads X-Git-Tag: tor-0.2.3.3-alpha~14^2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d1dd9991cd636bafe7543aea4dbb18de69f26202;p=thirdparty%2Ftor.git Document limitation of log_from_handle with partial reads --- diff --git a/src/common/util.c b/src/common/util.c index aa344bc9c6..76124ef06c 100644 --- a/src/common/util.c +++ b/src/common/util.c @@ -3654,6 +3654,9 @@ tor_split_lines(smartlist_t *sl, char *buf, int len) #ifdef MS_WINDOWS /** Read from stream, and send lines to log at the specified log level. * Returns -1 if there is a error reading, and 0 otherwise. + * If the generated stream is flushed more often than on new lines, or + * a read exceeds 256 bytes, lines will be truncated. This should be fixed, + * along with the corresponding problem on *nix (see bug #2045). */ static int log_from_handle(HANDLE *pipe, int severity)