From: Victor Stinner <vstinner@python.org>
Date: Wed, 18 Nov 2020 14:57:10 +0000 (+0100)
Subject: bpo-40998: Fix a refleak in create_filter() (GH-23365)
X-Git-Tag: v3.10.0a3~164
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d1e38d4023aa29e7ed64d4f8eb9c1e4a3c86a2e5;p=thirdparty%2FPython%2Fcpython.git

bpo-40998: Fix a refleak in create_filter() (GH-23365)
---

diff --git a/Python/_warnings.c b/Python/_warnings.c
index 8d33fbe0f878..313420c63148 100644
--- a/Python/_warnings.c
+++ b/Python/_warnings.c
@@ -69,12 +69,14 @@ create_filter(PyObject *category, _Py_Identifier *id, const char *modname)
             return NULL;
         }
     } else {
-        modname_obj = Py_None;
+        modname_obj = Py_NewRef(Py_None);
     }
 
     /* This assumes the line number is zero for now. */
-    return PyTuple_Pack(5, action_str, Py_None,
-                        category, modname_obj, _PyLong_GetZero());
+    PyObject *filter = PyTuple_Pack(5, action_str, Py_None,
+                                    category, modname_obj, _PyLong_GetZero());
+    Py_DECREF(modname_obj);
+    return filter;
 }
 #endif