From: Andreas Schneider <asn@samba.org>
Date: Tue, 4 Dec 2018 08:49:17 +0000 (+0100)
Subject: libcli:auth: Use 'bool ok' in ntv2_owf_gen()
X-Git-Tag: ldb-2.0.5~741
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d22aa6fcc23f83e86e134a4af1bb0cbc7fc93bba;p=thirdparty%2Fsamba.git

libcli:auth: Use 'bool ok' in ntv2_owf_gen()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/libcli/auth/smbencrypt.c b/libcli/auth/smbencrypt.c
index ded22d3175d..65d1bdce9bf 100644
--- a/libcli/auth/smbencrypt.c
+++ b/libcli/auth/smbencrypt.c
@@ -211,7 +211,6 @@ bool ntv2_owf_gen(const uint8_t owf[16],
 	smb_ucs2_t *domain;
 	size_t user_byte_len;
 	size_t domain_byte_len;
-	bool ret;
 	gnutls_hmac_hd_t hmac_hnd = NULL;
 	int rc;
 	bool ok = false;
@@ -235,15 +234,15 @@ bool ntv2_owf_gen(const uint8_t owf[16],
 		return false;
 	}
 
-	ret = push_ucs2_talloc(mem_ctx, &user, user_in, &user_byte_len );
-	if (!ret) {
+	ok = push_ucs2_talloc(mem_ctx, &user, user_in, &user_byte_len );
+	if (!ok) {
 		DEBUG(0, ("push_uss2_talloc() for user failed)\n"));
 		talloc_free(mem_ctx);
 		return false;
 	}
 
-	ret = push_ucs2_talloc(mem_ctx, &domain, domain_in, &domain_byte_len);
-	if (!ret) {
+	ok = push_ucs2_talloc(mem_ctx, &domain, domain_in, &domain_byte_len);
+	if (!ok) {
 		DEBUG(0, ("push_ucs2_talloc() for domain failed\n"));
 		talloc_free(mem_ctx);
 		return false;