From: Serhiy Storchaka <storchaka@gmail.com>
Date: Tue, 23 Jan 2024 21:27:04 +0000 (+0200)
Subject: gh-114492: Initialize struct termios before calling tcgetattr() (GH-114495)
X-Git-Tag: v3.13.0a4~354
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d22c066b802592932f9eb18434782299e80ca42e;p=thirdparty%2FPython%2Fcpython.git

gh-114492: Initialize struct termios before calling tcgetattr() (GH-114495)

On Alpine Linux it could leave some field non-initialized.
---

diff --git a/Misc/NEWS.d/next/Library/2024-01-23-21-20-40.gh-issue-114492.vKxl5o.rst b/Misc/NEWS.d/next/Library/2024-01-23-21-20-40.gh-issue-114492.vKxl5o.rst
new file mode 100644
index 000000000000..8df8299d0dff
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2024-01-23-21-20-40.gh-issue-114492.vKxl5o.rst
@@ -0,0 +1,2 @@
+Make the result of :func:`termios.tcgetattr` reproducible on Alpine Linux.
+Previously it could leave a random garbage in some fields.
diff --git a/Modules/termios.c b/Modules/termios.c
index c4f0fd9d5004..69dbd88be5fc 100644
--- a/Modules/termios.c
+++ b/Modules/termios.c
@@ -98,6 +98,8 @@ termios_tcgetattr_impl(PyObject *module, int fd)
     struct termios mode;
     int r;
 
+    /* Alpine Linux can leave some fields uninitialized. */
+    memset(&mode, 0, sizeof(mode));
     Py_BEGIN_ALLOW_THREADS
     r = tcgetattr(fd, &mode);
     Py_END_ALLOW_THREADS