From: Volker Lendecke <vl@samba.org>
Date: Thu, 5 Jun 2008 08:25:02 +0000 (+0200)
Subject: Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails
X-Git-Tag: samba-4.0.0alpha6~801^2~1166
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d261e16cfd4afc19db0c26cfb2b6389c9c174310;p=thirdparty%2Fsamba.git

Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails

This is really not a proper place to fix this, but as get_gc_list() and friends
are about to be replaced anyway, just work around the broken existing API
(This used to be commit df8d089bc63c2a52cbdf3504cded8df620a59902)
---

diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
index 37c0c4d0ac4..fc336d988b2 100644
--- a/source3/libads/ldap.c
+++ b/source3/libads/ldap.c
@@ -319,6 +319,7 @@ static NTSTATUS ads_find_dc(ADS_STRUCT *ads)
 
 	status = get_sorted_dc_list(realm, sitename, &ip_list, &count, got_realm);
 	if (!NT_STATUS_IS_OK(status)) {
+		SAFE_FREE(ip_list);
 		/* fall back to netbios if we can */
 		if ( got_realm && !lp_disable_netbios() ) {
 			got_realm = False;