From: Inada Naoki <songofacandy@gmail.com>
Date: Sun, 1 Nov 2020 11:02:03 +0000 (+0900)
Subject: tempfile: Use random.choises() instead of choise() (GH-23068)
X-Git-Tag: v3.10.0a2~21
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d2810054c7ee1b4ce925fc520224b595b53bf4b4;p=thirdparty%2FPython%2Fcpython.git

tempfile: Use random.choises() instead of choise() (GH-23068)
---

diff --git a/Lib/tempfile.py b/Lib/tempfile.py
index 770f72c25295..c3fe61aa0af4 100644
--- a/Lib/tempfile.py
+++ b/Lib/tempfile.py
@@ -143,10 +143,7 @@ class _RandomNameSequence:
         return self
 
     def __next__(self):
-        c = self.characters
-        choose = self.rng.choice
-        letters = [choose(c) for dummy in range(8)]
-        return ''.join(letters)
+        return ''.join(self.rng.choices(self.characters, k=8))
 
 def _candidate_tempdir_list():
     """Generate a list of candidate temporary directories which
diff --git a/Lib/test/test_tempfile.py b/Lib/test/test_tempfile.py
index 8ace883d74bb..77d710efaf10 100644
--- a/Lib/test/test_tempfile.py
+++ b/Lib/test/test_tempfile.py
@@ -153,8 +153,8 @@ class TestRandomNameSequence(BaseTestCase):
         self.r = tempfile._RandomNameSequence()
         super().setUp()
 
-    def test_get_six_char_str(self):
-        # _RandomNameSequence returns a six-character string
+    def test_get_eight_char_str(self):
+        # _RandomNameSequence returns a eight-character string
         s = next(self.r)
         self.nameCheck(s, '', '', '')