From: Anoop Saldanha <anoopsaldanha@gmail.com>
Date: Thu, 1 Aug 2013 12:22:48 +0000 (+0530)
Subject: fix for #915.  Fix segv when we send NULL to snprintf.
X-Git-Tag: suricata-2.0beta2~427
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d292f1a529f6c238a8f9b576a5d2bc99ccb3dabf;p=thirdparty%2Fsuricata.git

fix for #915.  Fix segv when we send NULL to snprintf.
---

diff --git a/src/log-pcap.c b/src/log-pcap.c
index 9a35b02c55..431bd2c131 100644
--- a/src/log-pcap.c
+++ b/src/log-pcap.c
@@ -262,12 +262,12 @@ TmEcode PcapLog (ThreadVars *t, Packet *p, void *data, PacketQueue *pq,
     len = sizeof(*pl->h) + GET_PKT_LEN(p);
 
     if (pl->filename == NULL) {
-        SCLogDebug("Opening PCAP log file %s", pl->filename);
         ret = PcapLogOpenFileCtx(pl);
         if (ret < 0) {
             SCMutexUnlock(&pl->plog_lock);
             return TM_ECODE_FAILED;
         }
+        SCLogDebug("Opening PCAP log file %s", pl->filename);
     }
 
     if (pl->mode == LOGMODE_SGUIL) {