From: Sami Kerola <kerolasa@iki.fi>
Date: Sat, 8 Aug 2020 19:06:42 +0000 (+0100)
Subject: login: ensure getutxid() does not use uninitialized variable [coverity scan]
X-Git-Tag: v2.37-rc1~415
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d2ab69ff6154566a378d584fd61c15cde9e576d0;p=thirdparty%2Futil-linux.git

login: ensure getutxid() does not use uninitialized variable [coverity scan]

Field ut.ut_pid is uninitialized when calling getutxline().  The safest
option is to ensure all struct data is initialized in the function.

CID: 360793
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/login-utils/login.c b/login-utils/login.c
index 5cd77acf4b..e2eb108024 100644
--- a/login-utils/login.c
+++ b/login-utils/login.c
@@ -698,9 +698,9 @@ done:
  */
 static void log_utmp(struct login_context *cxt)
 {
-	struct utmpx ut;
-	struct utmpx *utp;
-	struct timeval tv;
+	struct utmpx ut = {0};
+	struct utmpx *utp = NULL;
+	struct timeval tv = {0};
 
 	utmpxname(_PATH_UTMP);
 	setutxent();