From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 27 Dec 2017 11:43:31 +0000 (+0100)
Subject: cryptsetup: small if check improvement (#7747)
X-Git-Tag: v237~170
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d31eb24fc2dfbafa346c8cf3ab113f790cef4f0f;p=thirdparty%2Fsystemd.git

cryptsetup: small if check improvement (#7747)

It's a bit weird to test these strings after the fact instead of before.
Let's make sure that we don't even attempt the string escaping if the
strings are NULL.

Follow-up for #7688
---

diff --git a/src/cryptsetup/cryptsetup-generator.c b/src/cryptsetup/cryptsetup-generator.c
index b41faed6ad4..0b46e2db2a3 100644
--- a/src/cryptsetup/cryptsetup-generator.c
+++ b/src/cryptsetup/cryptsetup-generator.c
@@ -106,9 +106,11 @@ static int create_disk(
         if (r < 0)
                 return log_error_errno(r, "Failed to generate unit name: %m");
 
-        password_escaped = specifier_escape(password);
-        if (password && !password_escaped)
-                return log_oom();
+        if (password) {
+                password_escaped = specifier_escape(password);
+                if (!password_escaped)
+                        return log_oom();
+        }
 
         r = generator_open_unit_file(arg_dest, NULL, n, &f);
         if (r < 0)
@@ -176,9 +178,11 @@ static int create_disk(
         if (r < 0)
                 return r;
 
-        filtered_escaped = specifier_escape(filtered);
-        if (filtered && !filtered_escaped)
-                return log_oom();
+        if (filtered) {
+                filtered_escaped = specifier_escape(filtered);
+                if (!filtered_escaped)
+                        return log_oom();
+        }
 
         fprintf(f,
                 "\n[Service]\n"