From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 16 Jul 2012 15:38:39 +0000 (-0400)
Subject: Coverity 709056: Check return value on fputs in tor-gencert
X-Git-Tag: tor-0.2.3.20-rc~6^2~8
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d32f5081e1c41324a3464c30c487c6ef57a333d1;p=thirdparty%2Ftor.git

Coverity 709056: Check return value on fputs in tor-gencert
---

diff --git a/changes/cov709056 b/changes/cov709056
new file mode 100644
index 0000000000..64a75ad8a2
--- /dev/null
+++ b/changes/cov709056
@@ -0,0 +1,4 @@
+  o Minor bugfixes:
+    - Check return value of fputs() when writing authority certificate
+      file. Fixes Coverity issue 709056; bugfix on 0.2.0.1-alpha.
+
diff --git a/src/tools/tor-gencert.c b/src/tools/tor-gencert.c
index a8ffc07796..38b2101a3c 100644
--- a/src/tools/tor-gencert.c
+++ b/src/tools/tor-gencert.c
@@ -497,7 +497,12 @@ generate_certificate(void)
     return 1;
   }
 
-  fputs(buf, f);
+  if (fputs(buf, f) < 0) {
+    log_err(LD_GENERAL, "Couldn't write to %s: %s",
+            certificate_file, strerror(errno));
+    fclose(f);
+    return 1;
+  }
   fclose(f);
   return 0;
 }