From: Swen Schillig <swen@vnet.ibm.com>
Date: Fri, 25 May 2018 10:45:35 +0000 (+0200)
Subject: CID 1416475: possibly dereferencing NULL in fruit_pread_meta
X-Git-Tag: tevent-0.9.37~374
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d33c355103406ceb4941a479f34ea33eae8e87a7;p=thirdparty%2Fsamba.git

CID 1416475: possibly dereferencing NULL in fruit_pread_meta

Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jun 13 16:29:48 CEST 2018 on sn-devel-144
---

diff --git a/source3/modules/vfs_fruit.c b/source3/modules/vfs_fruit.c
index b1384c47850..078426290a4 100644
--- a/source3/modules/vfs_fruit.c
+++ b/source3/modules/vfs_fruit.c
@@ -4002,6 +4002,11 @@ static ssize_t fruit_pread_meta(vfs_handle_struct *handle,
 		return 0;
 	}
 
+	if (fio == NULL) {
+		DBG_ERR("Failed to fetch fsp extension");
+		return -1;
+	}
+
 	/* Yes, macOS always reads from offset 0 */
 	offset = 0;
 	to_return = MIN(n, AFP_INFO_SIZE);