From: Sébastien Darche Date: Fri, 26 Sep 2025 20:37:54 +0000 (-0400) Subject: [gdb/testsuite] fix gdb.server/server-kill.exp X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d3758513a81c81d6e62b135bff43ecca6608a65d;p=thirdparty%2Fbinutils-gdb.git [gdb/testsuite] fix gdb.server/server-kill.exp A test case in gdb.server/server-kill.exp attempts to query the server status after the server it is connected to has been killed. The connection is reset as expected, but the regex on the error message seems to be out-of-date. The test expects: Remote communication error. Target disconnected: Connection reset by peer. But a modern build of gdb yields : Remote communication error. Target disconnected: error while reading: Connection reset by peer. I presume this is due to change 0da23004a064 ("Change serial_readchar to throw") which added exceptions to the control flow handling instead of relying on perror(). The exception error string inserts "error while reading" to the perror message. The test appeared to fail intermittently, sometimes matching the first part of the regex ("Remote connection closed"). It now passes consistently. Change-Id: I3bf364b5d4b56de67f9ca30e9d636d3bb1be4119 Approved-by: Kevin Buettner --- diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp index 0c54918598c..f01f5e3912a 100644 --- a/gdb/testsuite/gdb.server/server-kill.exp +++ b/gdb/testsuite/gdb.server/server-kill.exp @@ -97,7 +97,7 @@ proc_with_prefix test_tstatus {} { # Force GDB to talk with GDBserver, so that we can get the # "connection closed" error. - gdb_test "tstatus" {Remote connection closed|Remote communication error\. Target disconnected: Connection reset by peer\.} + gdb_test "tstatus" {Remote connection closed|Remote communication error\. Target disconnected: error while reading: Connection reset by peer\.} } # Test unwinding with no debug/unwind info, right after the connection @@ -152,4 +152,3 @@ test_tstatus test_unwind_nosyms test_unwind_syms test_stepi -