From: Garming Sam Date: Mon, 23 Sep 2019 01:25:47 +0000 (+1200) Subject: join: provision_fill does not return anything X-Git-Tag: tevent-0.11.0~336 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d39715b86ad06293d5055ff2233b8e528623f986;p=thirdparty%2Fsamba.git join: provision_fill does not return anything Discovered by Semmle code analysis: https://lgtm.com/projects/g/samba-team/samba Signed-off-by: Garming Sam Reviewed-by: Douglas Bagnall --- diff --git a/python/samba/join.py b/python/samba/join.py index e7563ef9cb8..b557eac03eb 100644 --- a/python/samba/join.py +++ b/python/samba/join.py @@ -917,13 +917,13 @@ class DCJoinContext(object): secrets_ldb = Ldb(ctx.paths.secrets, session_info=system_session(), lp=ctx.lp) - presult = provision_fill(ctx.local_samdb, secrets_ldb, - ctx.logger, ctx.names, ctx.paths, - dom_for_fun_level=DS_DOMAIN_FUNCTION_2003, - targetdir=ctx.targetdir, samdb_fill=FILL_SUBDOMAIN, - machinepass=ctx.acct_pass, serverrole="active directory domain controller", - lp=ctx.lp, hostip=ctx.names.hostip, hostip6=ctx.names.hostip6, - dns_backend=ctx.dns_backend, adminpass=ctx.adminpass) + provision_fill(ctx.local_samdb, secrets_ldb, + ctx.logger, ctx.names, ctx.paths, + dom_for_fun_level=DS_DOMAIN_FUNCTION_2003, + targetdir=ctx.targetdir, samdb_fill=FILL_SUBDOMAIN, + machinepass=ctx.acct_pass, serverrole="active directory domain controller", + lp=ctx.lp, hostip=ctx.names.hostip, hostip6=ctx.names.hostip6, + dns_backend=ctx.dns_backend, adminpass=ctx.adminpass) print("Provision OK for domain %s" % ctx.names.dnsdomain) def create_replicator(ctx, repl_creds, binding_options):