From: Volker Lendecke <vl@samba.org>
Date: Sun, 14 Apr 2019 09:39:31 +0000 (+0200)
Subject: smbd: Use smbd_check_access_rights in reply_setatr()
X-Git-Tag: tdb-1.4.1~221
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d397d56717b804959367f04bbda49a5d704aa9da;p=thirdparty%2Fsamba.git

smbd: Use smbd_check_access_rights in reply_setatr()

That was the only caller of check_access outside of trans2.c, and it
passed an explicit NULL for fsp. Use the lower-level call, so we can
make check_access() static to trans2.c

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index 2cef4d01a01..ace0d71dbbe 100644
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -1539,8 +1539,8 @@ void reply_setatr(struct smb_request *req)
 		else
 			mode &= ~FILE_ATTRIBUTE_DIRECTORY;
 
-		status = check_access(conn, NULL, smb_fname,
-					FILE_WRITE_ATTRIBUTES);
+		status = smbd_check_access_rights(
+			conn, smb_fname, false, FILE_WRITE_ATTRIBUTES);
 		if (!NT_STATUS_IS_OK(status)) {
 			reply_nterror(req, status);
 			goto out;