From: Li Wang <liwang@kylinos.cn>
Date: Tue, 21 Apr 2026 03:38:16 +0000 (+0800)
Subject: fuse: drop redundant check in fuse_sync_bucket_alloc()
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d3aa89c9bfb7cd72a7025ebbb92275128d28afbd;p=thirdparty%2Flinux.git

fuse: drop redundant check in fuse_sync_bucket_alloc()

kzalloc_obj with __GFP_NOFAIL is documented to never return failure,
and checking for NULL is redundant (__GFP_NOFAIL in gfp_types.h).

Signed-off-by: Li Wang <liwang@kylinos.cn>
Reviewed-by: Joanne Koong <joannelkoong@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---

diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index 438d5211222c4..c3689f4f7beb8 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -676,11 +676,9 @@ static struct fuse_sync_bucket *fuse_sync_bucket_alloc(void)
 	struct fuse_sync_bucket *bucket;
 
 	bucket = kzalloc_obj(*bucket, GFP_KERNEL | __GFP_NOFAIL);
-	if (bucket) {
-		init_waitqueue_head(&bucket->waitq);
-		/* Initial active count */
-		atomic_set(&bucket->count, 1);
-	}
+	init_waitqueue_head(&bucket->waitq);
+	/* Initial active count */
+	atomic_set(&bucket->count, 1);
 	return bucket;
 }