From: Daniel Stenberg <daniel@haxx.se>
Date: Sat, 18 Oct 2025 21:34:52 +0000 (+0200)
Subject: rustls: exit on error
X-Git-Tag: rc-8_17_0-2~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d3b2ba92c7ed587d48afd1bbc58de19eab6645bf;p=thirdparty%2Fcurl.git

rustls: exit on error

In init_config_builder_verifier() the call to
rustls_root_cert_store_builder_build() set result on failure but did not
return.

Pointed out by ZeroPath
Closes #19125
---

diff --git a/lib/vtls/rustls.c b/lib/vtls/rustls.c
index ebd94213d4..2173b3be88 100644
--- a/lib/vtls/rustls.c
+++ b/lib/vtls/rustls.c
@@ -746,6 +746,9 @@ init_config_builder_verifier(struct Curl_easy *data,
   if(rr != RUSTLS_RESULT_OK) {
     rustls_failf(data, rr, "failed to build trusted root certificate store");
     result = CURLE_SSL_CACERT_BADFILE;
+    if(result) {
+      goto cleanup;
+    }
   }
 
   verifier_builder = rustls_web_pki_server_cert_verifier_builder_new(roots);
@@ -754,7 +757,7 @@ init_config_builder_verifier(struct Curl_easy *data,
     result = init_config_builder_verifier_crl(data,
                                              conn_config,
                                              verifier_builder);
-    if(result != CURLE_OK) {
+    if(result) {
       goto cleanup;
     }
   }