From: Michael Paquier <michael@paquier.xyz>
Date: Mon, 15 Jun 2026 23:31:39 +0000 (+0900)
Subject: pg_dump: Remove dead code in TAP tests
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d3b345eef3f3a08da724aa5681e3dbe6fbb1d91a;p=thirdparty%2Fpostgresql.git

pg_dump: Remove dead code in TAP tests

The schema_only_with_statistics test scenario was referenced in
002_pg_dump.pl, but was associated to no command sequence since
0ed92cf50cc4.

Issue discovered while investigating a different bug.  Perhaps this
cleanup is not worth backpatching, but there is also an argument in
favor of reducing noise when touching this area of the code in stable
branches.

Reviewed-by: Ewan Young <kdbase.hack@gmail.com>
Reviewed-by: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Discussion: https://postgr.es/m/ai-y0S7Z25NlrG_n@paquier.xyz
Backpatch-through: 18
---

diff --git a/src/bin/pg_dump/t/002_pg_dump.pl b/src/bin/pg_dump/t/002_pg_dump.pl
index bb59ea3dfcd..9258948b583 100644
--- a/src/bin/pg_dump/t/002_pg_dump.pl
+++ b/src/bin/pg_dump/t/002_pg_dump.pl
@@ -716,8 +716,7 @@ my %full_runs = (
 	no_table_access_method => 1,
 	pg_dumpall_dbprivs => 1,
 	pg_dumpall_exclude => 1,
-	schema_only => 1,
-	schema_only_with_statistics => 1,);
+	schema_only => 1,);
 
 # This is where the actual tests are defined.
 my %tests = (
@@ -934,7 +933,6 @@ my %tests = (
 			no_large_objects => 1,
 			no_owner => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 		},
 	},
 
@@ -1489,7 +1487,6 @@ my %tests = (
 		unlike => {
 			binary_upgrade => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 			no_large_objects => 1,
 		},
 	},
@@ -1514,7 +1511,6 @@ my %tests = (
 			binary_upgrade => 1,
 			no_large_objects => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 		},
 	},
 
@@ -1537,7 +1533,6 @@ my %tests = (
 			binary_upgrade => 1,
 			no_large_objects => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 		},
 	},
 
@@ -1704,7 +1699,6 @@ my %tests = (
 		unlike => {
 			no_large_objects => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 		},
 	},
 
@@ -1887,7 +1881,6 @@ my %tests = (
 			exclude_test_table => 1,
 			exclude_test_table_data => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 			only_dump_measurement => 1,
 		},
 	},
@@ -1913,7 +1906,6 @@ my %tests = (
 			binary_upgrade => 1,
 			exclude_dump_test_schema => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 			only_dump_measurement => 1,
 		},
 	},
@@ -1954,7 +1946,6 @@ my %tests = (
 			binary_upgrade => 1,
 			exclude_dump_test_schema => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 			only_dump_measurement => 1,
 		},
 	},
@@ -1978,7 +1969,6 @@ my %tests = (
 			binary_upgrade => 1,
 			exclude_dump_test_schema => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 			only_dump_measurement => 1,
 		},
 	},
@@ -2003,7 +1993,6 @@ my %tests = (
 			binary_upgrade => 1,
 			exclude_dump_test_schema => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 			only_dump_measurement => 1,
 		},
 	},
@@ -2027,7 +2016,6 @@ my %tests = (
 			binary_upgrade => 1,
 			exclude_dump_test_schema => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 			only_dump_measurement => 1,
 		},
 	},
@@ -2051,7 +2039,6 @@ my %tests = (
 			binary_upgrade => 1,
 			exclude_dump_test_schema => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 			only_dump_measurement => 1,
 		},
 	},
@@ -3670,7 +3657,6 @@ my %tests = (
 		unlike => {
 			binary_upgrade => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 			exclude_measurement => 1,
 			only_dump_test_schema => 1,
 			test_schema_plus_large_objects => 1,
@@ -4553,7 +4539,6 @@ my %tests = (
 			no_large_objects => 1,
 			no_privs => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 		},
 	},
 
@@ -4688,7 +4673,6 @@ my %tests = (
 			binary_upgrade => 1,
 			exclude_dump_test_schema => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 			only_dump_measurement => 1,
 		},
 	},
@@ -4705,7 +4689,6 @@ my %tests = (
 			binary_upgrade => 1,
 			exclude_dump_test_schema => 1,
 			schema_only => 1,
-			schema_only_with_statistics => 1,
 			only_dump_measurement => 1,
 		},
 	},
@@ -4906,7 +4889,6 @@ my %tests = (
 			statistics_only => 1,
 			statistics_only_with_schema => 1,
 			statistics_only_with_index => 1,
-			schema_only_with_statistics => 1,
 		},
 		unlike => {
 			exclude_dump_test_schema => 1,
@@ -4935,7 +4917,6 @@ my %tests = (
 			section_post_data => 1,
 			statistics_only => 1,
 			statistics_only_with_schema => 1,
-			schema_only_with_statistics => 1,
 		},
 		unlike => {
 			exclude_dump_test_schema => 1,
@@ -4967,7 +4948,6 @@ my %tests = (
 			statistics_only_with_schema => 1,
 			statistics_only_with_index => 1,
 			statistics_only_with_table => 1,
-			schema_only_with_statistics => 1,
 		},
 		unlike => {
 			no_statistics => 1,