From: Ondřej Surý <ondrej@sury.org>
Date: Thu, 4 Mar 2021 09:47:56 +0000 (+0100)
Subject: Fix comparison between signed and unsigned integer expressions
X-Git-Tag: v9.17.11~17^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d3bb3ae64fd022f8b250b679e0052a0655709c89;p=thirdparty%2Fbind9.git

Fix comparison between signed and unsigned integer expressions

Simple typecast to size_t should be enough to silence the warning on
ARMv7, even though the code is in fact correct, because the readlen is
checked for being < 0 in the block before the warning.
---

diff --git a/lib/isc/netmgr/http.c b/lib/isc/netmgr/http.c
index b90abce05c7..51adbea6f68 100644
--- a/lib/isc/netmgr/http.c
+++ b/lib/isc/netmgr/http.c
@@ -704,7 +704,7 @@ https_readcb(isc_nmhandle_t *handle, isc_result_t result, isc_region_t *region,
 		return;
 	}
 
-	if (readlen < region->length) {
+	if ((size_t)readlen < region->length) {
 		INSIST(session->bufsize == 0);
 		INSIST(region->length - readlen < MAX_DNS_MESSAGE_SIZE);
 		memmove(session->buf, region->base, region->length - readlen);