From: Volker Lendecke <vl@samba.org>
Date: Thu, 31 May 2018 18:56:31 +0000 (+0200)
Subject: dns: Simplify logic a bit
X-Git-Tag: tevent-0.9.37~436
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d3c82e686b18366ffa3db1cd4ed5c33bd3b0e86c;p=thirdparty%2Fsamba.git

dns: Simplify logic a bit

We've done an early return if (!found_tsig) a few lines before.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source4/dns_server/dns_crypto.c b/source4/dns_server/dns_crypto.c
index 0be9b8209aa..c8b5c46ad30 100644
--- a/source4/dns_server/dns_crypto.c
+++ b/source4/dns_server/dns_crypto.c
@@ -123,7 +123,7 @@ WERROR dns_verify_tsig(struct dns_server *dns,
 	}
 
 	/* The TSIG record needs to be the last additional record */
-	if (found_tsig && i + 1 != packet->arcount) {
+	if (i + 1 != packet->arcount) {
 		DEBUG(1, ("TSIG record not the last additional record!\n"));
 		return DNS_ERR(FORMAT_ERROR);
 	}