From: Sebastián Ramírez Date: Tue, 28 Jul 2026 13:47:58 +0000 (+0200) Subject: 🐛 Accept any base test failure as regression (#16092) X-Git-Tag: 0.140.10~4 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d3cd6054e4b5500deb5af7bece94d66a7ce1a70a;p=thirdparty%2Ffastapi%2Ffastapi.git 🐛 Accept any base test failure as regression (#16092) --- diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index cdd870a1ae..b5798dd378 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -262,20 +262,16 @@ jobs: git apply "$RUNNER_TEMP/tests.patch" uv sync --locked --no-dev --group tests --extra all set +e - mapfile -d '' -t changed_tests < "$RUNNER_TEMP/changed-tests" - uv run --no-sync pytest -- "${changed_tests[@]}" + xargs -0 uv run --no-sync pytest -- < "$RUNNER_TEMP/changed-tests" status=$? set -e if [ "$status" -eq 0 ]; then echo "::warning::The changed tests already pass on the base revision. Check whether the fix is still needed." echo "### Regression proof: base already passes :warning:" >> "$GITHUB_STEP_SUMMARY" echo "The changed tests pass without the pull request's code changes." >> "$GITHUB_STEP_SUMMARY" - elif [ "$status" -eq 1 ]; then - echo "The changed tests fail on the base revision as expected." - echo "### Regression proof: base fails as expected :white_check_mark:" >> "$GITHUB_STEP_SUMMARY" else - echo "::error::The base test run was inconclusive (pytest exit code $status)." - exit "$status" + echo "The changed tests fail on the base revision as expected (pytest exit code $status)." + echo "### Regression proof: base fails as expected :white_check_mark:" >> "$GITHUB_STEP_SUMMARY" fi coverage-combine: needs: