From: Björn Jacke <bjacke@samba.org>
Date: Mon, 25 Dec 2023 19:30:43 +0000 (+0100)
Subject: s4/ldap_backend: fix a NULL dereference
X-Git-Tag: talloc-2.4.2~182
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d4168fce7b07f417c81c801da0fd664fbb90715a;p=thirdparty%2Fsamba.git

s4/ldap_backend: fix a NULL dereference

Signed-off-by: Bjoern Jacke <bjacke@samba.org>>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source4/ldap_server/ldap_backend.c b/source4/ldap_server/ldap_backend.c
index 4e94417c21b..3bcd984f149 100644
--- a/source4/ldap_server/ldap_backend.c
+++ b/source4/ldap_server/ldap_backend.c
@@ -288,14 +288,15 @@ static NTSTATUS ldapsrv_encode(TALLOC_CTX *mem_ctx,
 				samba_ldap_control_handlers(),
 				&reply->blob,
 				mem_ctx);
-	TALLOC_FREE(reply->msg);
 	if (!bret) {
 		DEBUG(0,("Failed to encode ldap reply of type %d: "
 			 "ldap_encode() failed\n",
 			 reply->msg->type));
+		TALLOC_FREE(reply->msg);
 		return NT_STATUS_NO_MEMORY;
 	}
 
+	TALLOC_FREE(reply->msg);
 	talloc_set_name_const(reply->blob.data,
 			      "Outgoing, encoded single LDAP reply");