From: Volker Lendecke <vlendec@samba.org>
Date: Thu, 26 Jul 2007 17:27:03 +0000 (+0000)
Subject: r24058: Fix some memory leaks in ads_secrets_verify_ticket.
X-Git-Tag: samba-4.0.0alpha6~801^2~5239
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d44063715accb8129a4c047c965fba9732d7c044;p=thirdparty%2Fsamba.git

r24058: Fix some memory leaks in ads_secrets_verify_ticket.

Jeremy, Günther, please review!

Thanks,

Volker
(This used to be commit 000e096c277a71ca30c1c109aae62241ad466bee)
---

diff --git a/source3/libads/kerberos_verify.c b/source3/libads/kerberos_verify.c
index 378258ee087..ed889d027a9 100644
--- a/source3/libads/kerberos_verify.c
+++ b/source3/libads/kerberos_verify.c
@@ -274,6 +274,7 @@ static krb5_error_code ads_secrets_verify_ticket(krb5_context context,
 			auth_ok = True;
 			krb5_copy_keyblock(context, key, keyblock);
 			krb5_free_keyblock(context, key);
+			SAFE_FREE(key);
 			break;
 		}
 
@@ -285,10 +286,12 @@ static krb5_error_code ads_secrets_verify_ticket(krb5_context context,
 		if (ret == KRB5KRB_AP_ERR_TKT_NYV || 
 		    ret == KRB5KRB_AP_ERR_TKT_EXPIRED ||
 		    ret == KRB5KRB_AP_ERR_SKEW) {
+			SAFE_FREE(key);
 			break;
 		}
 
 		krb5_free_keyblock(context, key);
+		SAFE_FREE(key);
 
 	}