From: Nick Mathewson <nickm@torproject.org>
Date: Sat, 18 Nov 2017 15:26:45 +0000 (-0500)
Subject: Add an extra check in test_entrynodes
X-Git-Tag: tor-0.3.2.5-alpha~10^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d45bf0c65caa98b6e41046c22fbecf76cd8e1f8d;p=thirdparty%2Ftor.git

Add an extra check in test_entrynodes

This check makes it so we can reach "done" without setting "conn",
and so the "if (conn)" check will not be redundant, and so coverity
won't complain.  Fixes CID 1422205.  Not actually a bug.
---

diff --git a/src/test/test_entrynodes.c b/src/test/test_entrynodes.c
index 43cc394888..80ebebe3f8 100644
--- a/src/test/test_entrynodes.c
+++ b/src/test/test_entrynodes.c
@@ -2721,6 +2721,8 @@ test_entry_guard_outdated_dirserver_exclusion(void *arg)
     smartlist_add(digests, (char*)prose);
   }
 
+  tt_int_op(smartlist_len(digests), OP_EQ, 20);
+
   /* ... now mock some functions */
   mock_ns_val = tor_malloc_zero(sizeof(networkstatus_t));
   MOCK(networkstatus_get_latest_consensus_by_flavor, mock_ns_get_by_flavor);