From: Daniel Stenberg <daniel@haxx.se>
Date: Tue, 3 Oct 2000 16:53:41 +0000 (+0000)
Subject: add_buffer_send() free()d the buffer *before* it was used! :-O
X-Git-Tag: curl-7_4_1~37
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d46b006f22031af78e55830b3e359d3576d273fa;p=thirdparty%2Fcurl.git

add_buffer_send() free()d the buffer *before* it was used! :-O
---

diff --git a/lib/sendf.c b/lib/sendf.c
index 8042ac8b9e..723acc481f 100644
--- a/lib/sendf.c
+++ b/lib/sendf.c
@@ -194,17 +194,20 @@ send_buffer *add_buffer_init(void)
  */
 size_t add_buffer_send(int sockfd, struct connectdata *conn, send_buffer *in)
 {
-  if(in->buffer)
-    free(in->buffer);
-  free(in);
-
+  size_t amount;
   if(conn->data->bits.verbose) {
     fputs("> ", conn->data->err);
     /* this data _may_ contain binary stuff */
     fwrite(in->buffer, in->size_used, 1, conn->data->err);
   }
 
-  return ssend(sockfd, conn, in->buffer, in->size_used);
+  amount = ssend(sockfd, conn, in->buffer, in->size_used);
+
+  if(in->buffer)
+    free(in->buffer);
+  free(in);
+
+  return amount;
 }