From: Joe Perches <joe@perches.com>
Date: Tue, 24 Mar 2015 01:01:35 +0000 (-0700)
Subject: selinux: fix sel_write_enforce broken return value
X-Git-Tag: v3.16.35~2380
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d4af55bd8e4f9151aecbeace0446aa8d272841c9;p=thirdparty%2Fkernel%2Fstable.git

selinux: fix sel_write_enforce broken return value

commit 6436a123a147db51a0b06024a8350f4c230e73ff upstream.

Return a negative error value like the rest of the entries in this function.

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by:  Stephen Smalley <sds@tycho.nsa.gov>
[PM: tweaked subject line]
Signed-off-by: Paul Moore <pmoore@redhat.com>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
---

diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
index 33db1ad4fd103..138949a31eabe 100644
--- a/security/selinux/selinuxfs.c
+++ b/security/selinux/selinuxfs.c
@@ -152,7 +152,7 @@ static ssize_t sel_write_enforce(struct file *file, const char __user *buf,
 		goto out;
 
 	/* No partial writes. */
-	length = EINVAL;
+	length = -EINVAL;
 	if (*ppos != 0)
 		goto out;