From: Gregory P. Smith <greg@krypto.org>
Date: Sun, 11 Nov 2012 08:08:45 +0000 (-0800)
Subject: Remove the subprocess "bad exception data" warning (formerly a print!)
X-Git-Tag: v3.4.0a1~2033
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d4b645ef423667f179f136bee711b8ca85bd28d8;p=thirdparty%2FPython%2Fcpython.git

Remove the subprocess "bad exception data" warning (formerly a print!)
all together and just include the repr of the data in the exception
itself instead of the useless string "Unknown".

This code path is unlikely to even be possible to take given the
nature of the pipe it gets subprocess data from.
---

d4b645ef423667f179f136bee711b8ca85bd28d8
diff --cc Lib/subprocess.py
index d52f9a45f398,dad7b1670d08..0fff36fa5d67
--- a/Lib/subprocess.py
+++ b/Lib/subprocess.py
@@@ -1412,14 -1412,13 +1412,13 @@@ class Popen(object)
                      exception_name, hex_errno, err_msg = (
                              errpipe_data.split(b':', 2))
                  except ValueError:
-                     warnings.warn(RuntimeWarning(
-                             'Bad exception data: %r' % errpipe_data))
 -                    exception_name = b'RuntimeError'
 +                    exception_name = b'SubprocessError'
                      hex_errno = b'0'
-                     err_msg = b'Unknown'
+                     err_msg = (b'Bad exception data from child: ' +
+                                repr(errpipe_data))
                  child_exception_type = getattr(
                          builtins, exception_name.decode('ascii'),
 -                        RuntimeError)
 +                        SubprocessError)
                  for fd in (p2cwrite, c2pread, errread):
                      if fd != -1:
                          os.close(fd)
diff --cc Misc/NEWS
index 30e32173683b,cd923b371e05..ba474d8d2bbb
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@@ -116,9 -83,9 +116,12 @@@ Core and Builtin
  Library
  -------
  
+ - Remove a bare print to stdout from the subprocess module that could have
+   happened if the child process wrote garbage to its pre-exec error pipe.
+ 
 +- The subprocess module now raises its own SubprocessError instead of a
 +  RuntimeError in various error situations which should not normally happen.
 +
  - Issue #16327: The subprocess module no longer leaks file descriptors
    used for stdin/stdout/stderr pipes to the child when fork() fails.