From: Günther Deschner Date: Mon, 18 Aug 2025 15:14:00 +0000 (+0200) Subject: nsswitch/libwbclient: Fix CID #1034862 Resource leak X-Git-Tag: talloc-2.4.4~119 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d4d231dc50f1bbf42ae8cd8fb49f96ae6c4c0ee8;p=thirdparty%2Fsamba.git nsswitch/libwbclient: Fix CID #1034862 Resource leak Guenther Signed-off-by: Guenther Deschner Reviewed-by: Anoop C S Autobuild-User(master): Anoop C S Autobuild-Date(master): Tue Aug 19 09:45:46 UTC 2025 on atb-devel-224 --- diff --git a/nsswitch/libwbclient/tests/wbclient.c b/nsswitch/libwbclient/tests/wbclient.c index 0238ad69ec7..a58e65023da 100644 --- a/nsswitch/libwbclient/tests/wbclient.c +++ b/nsswitch/libwbclient/tests/wbclient.c @@ -231,16 +231,18 @@ static bool test_wbc_sidtostring(struct torture_context *tctx) struct wbcDomainSid sid; const char *sid_string = "S-1-5-32"; char *sid_string2; + bool ret = true; torture_assert_wbc_ok(tctx, wbcStringToSid(sid_string, &sid), "wbcStringToSid of %s failed", sid_string); torture_assert_wbc_ok(tctx, wbcSidToString(&sid, &sid_string2), "wbcSidToString of %s failed", sid_string); - torture_assert_str_equal(tctx, sid_string, sid_string2, + torture_assert_str_equal_goto(tctx, sid_string, sid_string2, ret, done, "sid strings differ"); + done: wbcFreeMemory(sid_string2); - return true; + return ret; } static bool test_wbc_guidtostring(struct torture_context *tctx)