From: Andrew Bartlett <abartlet@samba.org>
Date: Tue, 19 Nov 2019 20:59:07 +0000 (+1300)
Subject: ndrdump: Check for input decode failures
X-Git-Tag: ldb-2.1.0~664
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d4eabfb763b7c0ea6b112ea3a129977a68466977;p=thirdparty%2Fsamba.git

ndrdump: Check for input decode failures

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/librpc/tools/ndrdump.c b/librpc/tools/ndrdump.c
index 18c32462532..31f82c27d99 100644
--- a/librpc/tools/ndrdump.c
+++ b/librpc/tools/ndrdump.c
@@ -505,6 +505,12 @@ static void ndr_print_dummy(struct ndr_print *ndr, const char *format, ...)
 		blob = data_blob_const(data, size);
 	}
 
+	if (data != NULL && blob.data == NULL) {
+		printf("failed to decode input data\n");
+		TALLOC_FREE(mem_ctx);
+		exit(1);
+	}
+
 	ndr_pull = ndr_pull_init_blob(&blob, mem_ctx);
 	if (ndr_pull == NULL) {
 		perror("ndr_pull_init_blob");