From: Volker Lendecke <vl@samba.org>
Date: Wed, 24 Jan 2018 11:57:43 +0000 (+0100)
Subject: libnmb: Fix CID 1428474 Incorrect expression (COPY_PASTE_ERROR)
X-Git-Tag: tevent-0.9.36~269
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d4f7d9e08ca690b8278b35690dfb9e4673c19e00;p=thirdparty%2Fsamba.git

libnmb: Fix CID 1428474 Incorrect expression (COPY_PASTE_ERROR)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Jan 25 01:53:53 CET 2018 on sn-devel-144
---

diff --git a/source3/libsmb/nmblib.c b/source3/libsmb/nmblib.c
index bac43400b3a..5bfc129ebf5 100644
--- a/source3/libsmb/nmblib.c
+++ b/source3/libsmb/nmblib.c
@@ -840,7 +840,7 @@ static struct packet_struct *copy_packet_talloc(
 			ndst->additional = talloc_memdup(
 				pkt, nsrc->additional,
 				sizeof(struct res_rec) * nsrc->header.arcount);
-			if (ndst->nsrecs == NULL) {
+			if (ndst->additional == NULL) {
 				goto fail;
 			}
 		}