From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Sun, 18 Sep 2022 14:32:21 +0000 (+0900)
Subject: udev: do not ignore -ENOENT from sd_device_get_devname() for block device
X-Git-Tag: v252-rc1~148^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d50c55bd435a5c338665da1cb83df88b49b96eff;p=thirdparty%2Fsystemd.git

udev: do not ignore -ENOENT from sd_device_get_devname() for block device

We already checked that the sd_device object 'dev' is for a whole block
device. So, -ENOENT should not be triggeered here, and if it is, there
exists something spurious. Hence we should not ignore the failure.
---

diff --git a/src/udev/udevd.c b/src/udev/udevd.c
index 9900a9363ea..5ea197c1c48 100644
--- a/src/udev/udevd.c
+++ b/src/udev/udevd.c
@@ -495,8 +495,6 @@ static int device_get_whole_disk(sd_device *dev, sd_device **ret_device, const c
                 return log_device_debug_errno(dev, r, "Failed to get whole disk device: %m");
 
         r = sd_device_get_devname(dev, &val);
-        if (r == -ENOENT)
-                goto irrelevant;
         if (r < 0)
                 return log_device_debug_errno(dev, r, "Failed to get devname: %m");