From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 18 May 2015 21:54:05 +0000 (+0200)
Subject: journalctl: free all command line argument objects
X-Git-Tag: v220~71
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d52da2057f06c49d50ed99300dc407c0227b1a32;p=thirdparty%2Fsystemd.git

journalctl: free all command line argument objects

let's try to be valgrind clean
---

diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c
index fa2be3b55ff..3a59d7ff1be 100644
--- a/src/journal/journalctl.c
+++ b/src/journal/journalctl.c
@@ -37,7 +37,6 @@
 
 #include "sd-journal.h"
 #include "sd-bus.h"
-
 #include "log.h"
 #include "logs-show.h"
 #include "util.h"
@@ -1915,8 +1914,6 @@ int main(int argc, char *argv[]) {
                 goto finish;
 
         r = add_units(j);
-        arg_system_units = strv_free(arg_system_units);
-        arg_user_units = strv_free(arg_user_units);
         if (r < 0) {
                 log_error_errno(r, "Failed to add filter for units: %m");
                 goto finish;
@@ -2183,5 +2180,9 @@ finish:
 
         strv_free(arg_file);
 
+        strv_free(arg_syslog_identifier);
+        strv_free(arg_system_units);
+        strv_free(arg_user_units);
+
         return r < 0 ? EXIT_FAILURE : EXIT_SUCCESS;
 }