From: rl1987 <rl1987@sdf.lonestar.org>
Date: Thu, 26 Apr 2018 09:25:16 +0000 (+0200)
Subject: Log a notice when changing to/from wildcard IP address
X-Git-Tag: tor-0.3.5.1-alpha~47^2~12
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d548453abdf6ed708b6cb7e0a58f11d40f0cf4d1;p=thirdparty%2Ftor.git

Log a notice when changing to/from wildcard IP address
---

diff --git a/src/core/mainloop/connection.c b/src/core/mainloop/connection.c
index 1cc83016fd..f435b29853 100644
--- a/src/core/mainloop/connection.c
+++ b/src/core/mainloop/connection.c
@@ -2843,12 +2843,11 @@ retry_all_listeners(smartlist_t *new_conns, int close_all_noncontrol)
       connection_listener_new_for_port(r->new_port, &skip, &addr_in_use);
     connection_t *old_conn = r->old_conn;
 
-
     if (skip)
       continue;
 
-    connection_close_immediate(r->old_conn);
-    connection_mark_for_close(r->old_conn);
+    connection_close_immediate(old_conn);
+    connection_mark_for_close(old_conn);
 
     if (addr_in_use) {
       new_conn = connection_listener_new_for_port(r->new_port,
@@ -2859,6 +2858,11 @@ retry_all_listeners(smartlist_t *new_conns, int close_all_noncontrol)
 
     smartlist_add(new_conns, new_conn);
 
+    log_notice(LD_NET, "Closed no-longer-configured %s on %s:%d "
+                       "(replaced by %s:%d)",
+               conn_type_to_string(old_conn->type), old_conn->address,
+               old_conn->port, new_conn->address, new_conn->port);
+
     tor_free(r);
     SMARTLIST_DEL_CURRENT(replacements, r);
   } SMARTLIST_FOREACH_END(r);