From: Noel Power Date: Thu, 4 Jul 2019 11:50:29 +0000 (+0000) Subject: s4/dsdb/schema: clang: Fix Array access results in null pointer deref X-Git-Tag: samba-4.11.0rc1~20 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d54f9aaf81e03d6a7d0e270a88c744f51af507f7;p=thirdparty%2Fsamba.git s4/dsdb/schema: clang: Fix Array access results in null pointer deref Fixes: source4/dsdb/schema/schema_query.c:223:15: warning: Array access (from variable 'attr_list') results in a null pointer dereference <--[clang] attr_list[i] = NULL; ~~~~~~~~~ ^ 1 warning generated. Signed-off-by: Noel Power Reviewed-by: Gary Lockyer --- diff --git a/source4/dsdb/schema/schema_query.c b/source4/dsdb/schema/schema_query.c index 8a582161721..848f6cbd5b1 100644 --- a/source4/dsdb/schema/schema_query.c +++ b/source4/dsdb/schema/schema_query.c @@ -220,7 +220,9 @@ WERROR dsdb_linked_attribute_lDAPDisplayName_list(const struct dsdb_schema *sche attr_list[i] = cur->lDAPDisplayName; i++; } - attr_list[i] = NULL; + if (attr_list != NULL && attr_list[i] != NULL) { + attr_list[i] = NULL; + } *attr_list_ret = attr_list; return WERR_OK; }