From: Paul Menzel <paulepanter@users.sourceforge.net>
Date: Thu, 3 Oct 2013 12:37:31 +0000 (+0200)
Subject: rtc_linux.c: Remove useless assignment `error = -1;`
X-Git-Tag: 1.30-pre1~187
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d5a9c1535eef53a9cd8356b0aea05a8d51bbaf08;p=thirdparty%2Fchrony.git

rtc_linux.c: Remove useless assignment `error = -1;`

The Clang static analyzer scan-build from Debian clang version 3.4-1
found the following unneeded assignment.

        rtc_linux.c:756:5: warning: Value stored to 'error' is never read
            error = 1;
            ^       ~

Indeed, if in that if branch, the function returns without ever looking
at the variable `error`. So remove the line.
---

diff --git a/rtc_linux.c b/rtc_linux.c
index 9fe0ffb2..6e1771b4 100644
--- a/rtc_linux.c
+++ b/rtc_linux.c
@@ -753,7 +753,6 @@ read_from_device(void *any)
     /* This looks like a bad error : the file descriptor was indicating it was
      * ready to read but we couldn't read anything.  Give up. */
     LOG(LOGS_ERR, LOGF_RtcLinux, "Could not read flags %s : %s", CNF_GetRtcDevice(), strerror(errno));
-    error = 1;
     SCH_RemoveInputFileHandler(fd);
     switch_interrupts(0); /* Likely to raise error too, but just to be sure... */
     close(fd);