From: Dave Hart <hart@ntp.org>
Date: Fri, 17 Oct 2025 07:35:53 +0000 (+0000)
Subject: [Bug 3053] Frequency prediction algorithm precedence error.
X-Git-Tag: NTP_4_3_108~3^2^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d5b40ecf2a3034c6cc22fcf6ef0bff59822cdf55;p=thirdparty%2Fntp.git

[Bug 3053] Frequency prediction algorithm precedence error.

bk: 68f1f1d96VDp3C0Zoawg-8tR1xkw0g
---

diff --git a/ChangeLog b/ChangeLog
index df15157be0..07d0753a93 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,7 @@
 ---
 * [Bug 3960] Remove duplicate ntp.conf.def content, reported by
              Ulrich Windl. <stenn@ntp.org>
+* [Bug 3053] Frequency prediction algorithm precedence error. <hart@ntp.org>
 * Makefile.am: Another tweak to check-local.  <stenn@ntp.org>
 * cleanup github-specific files.  <stenn@ntp.org>
 * Add COPYRIGHT.md and LICENSE.md.  <stenn@ntp.org>
diff --git a/ntpd/ntp_loopfilter.c b/ntpd/ntp_loopfilter.c
index 6378e0d7e6..2088a18985 100644
--- a/ntpd/ntp_loopfilter.c
+++ b/ntpd/ntp_loopfilter.c
@@ -705,12 +705,12 @@ local_clock(
 				 * becomes ineffective above the Allan intercept
 				 * where the FLL becomes effective.
 				 */
-				if (sys_poll >= allan_xpt)
+				if (sys_poll >= allan_xpt) {
 					clock_frequency +=
 					      (fp_offset - clock_offset)
-					    / ( max(ULOGTOD(sys_poll), mu)
-					       * CLOCK_FLL);
-
+					      / max(ULOGTOD(sys_poll), mu)
+					      * CLOCK_FLL;
+				}
 				/*
 				 * The PLL frequency gain (numerator) depends on
 				 * the minimum of the update interval and Allan