From: Jelte Jansen Date: Wed, 20 Feb 2013 16:19:58 +0000 (+0100) Subject: [2713] Use SYSCONFDIR for csv file X-Git-Tag: bind10-1.1.0beta1-release~68^2~11 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d5b8d3d8ddea4161a63f0653d1a56dffe2297bdc;p=thirdparty%2Fkea.git [2713] Use SYSCONFDIR for csv file I know it's a different ticket but it seemed to easy not to do here Also fixed a coupld of distcheck issues with .pyc files --- diff --git a/src/bin/usermgr/Makefile.am b/src/bin/usermgr/Makefile.am index 08c9f9ab2c..540d675c0e 100644 --- a/src/bin/usermgr/Makefile.am +++ b/src/bin/usermgr/Makefile.am @@ -4,7 +4,7 @@ sbin_SCRIPTS = b10-cmdctl-usermgr b10_cmdctl_usermgrdir = $(pkgdatadir) -CLEANFILES= b10-cmdctl-usermgr +CLEANFILES= b10-cmdctl-usermgr b10-cmdctl-usermgr.pyc man_MANS = b10-cmdctl-usermgr.8 DISTCLEANFILES = $(man_MANS) @@ -27,3 +27,7 @@ endif b10-cmdctl-usermgr: b10-cmdctl-usermgr.py $(SED) "s|@@PYTHONPATH@@|@pyexecdir@|" b10-cmdctl-usermgr.py >$@ chmod a+x $@ + +CLEANDIRS = __pycache__ +clean-local: + rm -rf $(CLEANDIRS) diff --git a/src/bin/usermgr/b10-cmdctl-usermgr.py.in b/src/bin/usermgr/b10-cmdctl-usermgr.py.in index 3cb0eea4a2..8f6216c689 100644 --- a/src/bin/usermgr/b10-cmdctl-usermgr.py.in +++ b/src/bin/usermgr/b10-cmdctl-usermgr.py.in @@ -19,6 +19,7 @@ This file implements user management program. The user name and its password is appended to csv file. ''' +from bind10_config import SYSCONFPATH import random from hashlib import sha1 import csv @@ -31,7 +32,7 @@ import isc.util.process isc.util.process.rename() VERSION_STRING = 'b10-cmdctl-usermgr @PACKAGE_VERSION@' -DEFAULT_FILE = 'cmdctl-accounts.csv' +DEFAULT_FILE = SYSCONFPATH + '/cmdctl-accounts.csv' class UserManager: def __init__(self, options): diff --git a/src/bin/usermgr/tests/b10-cmdctl-usermgr_test.py b/src/bin/usermgr/tests/b10-cmdctl-usermgr_test.py index 6a233101b5..5d69a41795 100644 --- a/src/bin/usermgr/tests/b10-cmdctl-usermgr_test.py +++ b/src/bin/usermgr/tests/b10-cmdctl-usermgr_test.py @@ -19,6 +19,7 @@ import imp import os import subprocess import unittest +from bind10_config import SYSCONFPATH def run(command): """ @@ -155,7 +156,8 @@ Options: """ # Hardcoded path .. should be ok since this is run from make check usermgr = imp.load_source('usermgr', '../b10-cmdctl-usermgr.py') - self.assertEqual('cmdctl-accounts.csv', usermgr.DEFAULT_FILE) + self.assertEqual(SYSCONFPATH + '/cmdctl-accounts.csv', + usermgr.DEFAULT_FILE) if __name__== '__main__': unittest.main() diff --git a/src/lib/python/bind10_config.py.in b/src/lib/python/bind10_config.py.in index 9cd8d66ad7..2840d19d31 100644 --- a/src/lib/python/bind10_config.py.in +++ b/src/lib/python/bind10_config.py.in @@ -24,11 +24,13 @@ def reload(): global PLUGIN_PATHS global PREFIX global LIBEXECPATH + global SYSCONFPATH BIND10_MSGQ_SOCKET_FILE = os.path.join("@localstatedir@", "@PACKAGE_NAME@", "msgq_socket").replace("${prefix}", "@prefix@") PREFIX = "@prefix@" + SYSCONFPATH="@sysconfdir@/@PACKAGE@".replace('${prefix}', PREFIX) # B10_FROM_SOURCE is set in the environment for internal tests and # an experimental run without installagion. In that case we need to