From: Nick Mathewson <nickm@torproject.org>
Date: Thu, 16 May 2019 19:34:28 +0000 (-0400)
Subject: test_channel_listener: free 'chan' explicitly
X-Git-Tag: tor-0.4.1.2-alpha~21^2^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d5db40a0145457f6a1ee24ac1310511eaf62b959;p=thirdparty%2Ftor.git

test_channel_listener: free 'chan' explicitly

This should fix CID 1437442, where coverity can't tell that
channel_free_all() frees the fake channel we allocated.
---

diff --git a/src/test/test_channel.c b/src/test/test_channel.c
index 4c2bbc86b4..6a6bc9d810 100644
--- a/src/test/test_channel.c
+++ b/src/test/test_channel.c
@@ -1540,6 +1540,10 @@ test_channel_listener(void *arg)
   channel_listener_dump_statistics(chan, LOG_INFO);
 
  done:
+  if (chan) {
+    channel_listener_unregister(chan);
+    tor_free(chan);
+  }
   channel_free_all();
 }
 
@@ -1566,4 +1570,3 @@ struct testcase_t channel_tests[] = {
     NULL, NULL },
   END_OF_TESTCASES
 };
-