From: Volker Lendecke <vl@samba.org>
Date: Thu, 5 Apr 2018 08:11:16 +0000 (+0200)
Subject: eventlog: Fix CID 242105 Unchecked return value
X-Git-Tag: ldb-1.4.0~719
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d5ef8dbeef36eeb30fa94efae1d6df8647679812;p=thirdparty%2Fsamba.git

eventlog: Fix CID 242105 Unchecked return value

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/lib/eventlog/eventlog.c b/source3/lib/eventlog/eventlog.c
index f9ac0900150..cc4573c869c 100644
--- a/source3/lib/eventlog/eventlog.c
+++ b/source3/lib/eventlog/eventlog.c
@@ -966,7 +966,10 @@ NTSTATUS evlog_tdb_entry_to_evt_entry(TALLOC_CTX *mem_ctx,
 			return NT_STATUS_INVALID_SID;
 		}
 		if (len > 0) {
-			string_to_sid(&e->UserSid, sid_str);
+			bool ok = string_to_sid(&e->UserSid, sid_str);
+			if (!ok) {
+				return NT_STATUS_INVALID_SID;
+			}
 		}
 	}