From: Michael Wood <esiotrot@gmail.com>
Date: Fri, 20 Jan 2012 06:30:18 +0000 (+0200)
Subject: Log short_princ instead of uninitialised filter.
X-Git-Tag: tevent-0.9.15~276
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d65f33de1d14be22a159211f0c835b6fe170cc14;p=thirdparty%2Fsamba.git

Log short_princ instead of uninitialised filter.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Jan 21 13:06:35 CET 2012 on sn-devel-104
---

diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c
index ae93b75befe..77c84303a52 100644
--- a/source4/kdc/db-glue.c
+++ b/source4/kdc/db-glue.c
@@ -1363,7 +1363,6 @@ static krb5_error_code samba_kdc_lookup_server(krb5_context context,
 
 	} else {
 		int lret;
-		char *filter = NULL;
 		char *short_princ;
 		const char *realm;
 		/* server as client principal case, but we must not lookup userPrincipalNames */
@@ -1386,16 +1385,18 @@ static krb5_error_code samba_kdc_lookup_server(krb5_context context,
 				       DSDB_SEARCH_SHOW_EXTENDED_DN | DSDB_SEARCH_NO_GLOBAL_CATALOG,
 				       "(&(objectClass=user)(samAccountName=%s))",
 				       ldb_binary_encode_string(mem_ctx, short_princ));
-		free(short_princ);
 		if (lret == LDB_ERR_NO_SUCH_OBJECT) {
-			DEBUG(3, ("Failed find a entry for %s\n", filter));
+			DEBUG(3, ("Failed to find an entry for %s\n", short_princ));
+			free(short_princ);
 			return HDB_ERR_NOENTRY;
 		}
 		if (lret != LDB_SUCCESS) {
-			DEBUG(3, ("Failed single search for for %s - %s\n",
-				  filter, ldb_errstring(kdc_db_ctx->samdb)));
+			DEBUG(3, ("Failed single search for %s - %s\n",
+				  short_princ, ldb_errstring(kdc_db_ctx->samdb)));
+			free(short_princ);
 			return HDB_ERR_NOENTRY;
 		}
+		free(short_princ);
 	}
 
 	return 0;