From: Nick Mathewson <nickm@torproject.org>
Date: Wed, 17 Jul 2019 13:28:48 +0000 (+0200)
Subject: Add a TOR_DISABLE_PRACTRACKER envvar for use by folks who don't care
X-Git-Tag: tor-0.4.2.1-alpha~116^2~10
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d6a3636cdcb2556e99744dc3685db2010e151291;p=thirdparty%2Ftor.git

Add a TOR_DISABLE_PRACTRACKER envvar for use by folks who don't care

Fixes part of bug 30752
---

diff --git a/Makefile.am b/Makefile.am
index e823f9e103..d6ea72c17a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -369,7 +369,9 @@ endif
 
 check-best-practices:
 if USEPYTHON
-	$(PYTHON) $(top_srcdir)/scripts/maint/practracker/practracker.py $(top_srcdir)
+	@if test "$$TOR_DISABLE_PRACTRACKER" = ""; then \
+		$(PYTHON) $(top_srcdir)/scripts/maint/practracker/practracker.py $(top_srcdir); \
+	fi
 endif
 
 practracker-regen:
diff --git a/scripts/maint/practracker/practracker.py b/scripts/maint/practracker/practracker.py
index 75cd44d228..70035a0ab6 100755
--- a/scripts/maint/practracker/practracker.py
+++ b/scripts/maint/practracker/practracker.py
@@ -227,6 +227,9 @@ Please fix the problems if you can, and update the exceptions file
 ({}) if you can't.
 
 See doc/HACKING/HelpfulTools.md for more information on using practracker.\
+
+You can disable this message by setting the TOR_DISABLE_PRACTRACKER environment
+variable.
 """.format(found_new_issues, exceptions_file)
         print(new_issues_str)