From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Wed, 7 Oct 2020 02:06:27 +0000 (+0900)
Subject: network: free Route object when route_remove() fails
X-Git-Tag: v247-rc1~110^2~8
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d6ad41e27d37518ce9068a74dcd9380de90ee4a9;p=thirdparty%2Fsystemd.git

network: free Route object when route_remove() fails

When route_remove() succeeds, the Route object will be freed later by
manager_rtnl_process_route().
---

diff --git a/src/network/networkd-route.c b/src/network/networkd-route.c
index 5df5f8fb6c5..feb62ee7836 100644
--- a/src/network/networkd-route.c
+++ b/src/network/networkd-route.c
@@ -760,10 +760,10 @@ static int route_expire_handler(sd_event_source *s, uint64_t usec, void *userdat
         assert(route);
 
         r = route_remove(route, route->manager, route->link, NULL);
-        if (r < 0)
+        if (r < 0) {
                 log_link_warning_errno(route->link, r, "Could not remove route: %m");
-        else
                 route_free(route);
+        }
 
         return 1;
 }