From: Mark Andrews <marka@isc.org>
Date: Wed, 21 Sep 2022 01:54:48 +0000 (+1000)
Subject: Stop passing mctx to dns_rdata_tostruct as it is unnecessary for SIG
X-Git-Tag: v9.19.6~39^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d6ad56bd9e98382f8bd41a25756efdbbc3e39bd9;p=thirdparty%2Fbind9.git

Stop passing mctx to dns_rdata_tostruct as it is unnecessary for SIG

dns_rdata_tostruct doesn't need a mctx passed to it for SIG (the signer
is already expanded at this point). About the only time when mctx is
needed is when the structure is to be used after the rdata has been
destroyed.
---

diff --git a/lib/dns/message.c b/lib/dns/message.c
index 0995821fb68..b67d6d299c9 100644
--- a/lib/dns/message.c
+++ b/lib/dns/message.c
@@ -3167,7 +3167,7 @@ dns_message_checksig(dns_message_t *msg, dns_view_t *view) {
 			return (ISC_R_UNEXPECTEDEND);
 		}
 
-		result = dns_rdata_tostruct(&rdata, &sig, msg->mctx);
+		result = dns_rdata_tostruct(&rdata, &sig, NULL);
 		if (result != ISC_R_SUCCESS) {
 			return (result);
 		}