From: Andrej Gessel <Andrej.Gessel@janztec.com>
Date: Mon, 16 Jul 2018 09:43:22 +0000 (+0200)
Subject: fix mem leak in ldbsearch
X-Git-Tag: ldb-1.5.1~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d71c655eecc7bc7963a8858dd3a631ac1e580046;p=thirdparty%2Fsamba.git

fix mem leak in ldbsearch

Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/lib/ldb/tools/ldbsearch.c b/lib/ldb/tools/ldbsearch.c
index 5eae6242a99..374f2405e47 100644
--- a/lib/ldb/tools/ldbsearch.c
+++ b/lib/ldb/tools/ldbsearch.c
@@ -248,12 +248,16 @@ again:
 
 	ret = ldb_request(ldb, req);
 	if (ret != LDB_SUCCESS) {
+		talloc_free(sctx);
+		talloc_free(req);
 		printf("search failed - %s\n", ldb_errstring(ldb));
 		return ret;
 	}
 
 	ret = ldb_wait(req->handle, LDB_WAIT_ALL);
 	if (ret != LDB_SUCCESS) {
+		talloc_free(sctx);
+		talloc_free(req);
 		printf("search error - %s\n", ldb_errstring(ldb));
 		return ret;
 	}
@@ -318,6 +322,7 @@ int main(int argc, const char **argv)
 	if (options->basedn != NULL) {
 		basedn = ldb_dn_new(ldb, ldb, options->basedn);
 		if (basedn == NULL) {
+			talloc_free(mem_ctx);
 			return LDB_ERR_OPERATIONS_ERROR;
 		}
 	}