From: Stephen Hemminger Date: Fri, 12 Dec 2008 18:27:08 +0000 (-0800) Subject: net: eliminate warning from NETIF_F_UFO on bridge X-Git-Tag: v2.6.27.10~13 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d79c98afbdd27d20777d9b7558240db66d69ca37;p=thirdparty%2Fkernel%2Fstable.git net: eliminate warning from NETIF_F_UFO on bridge Based on commit b63365a2d60268a3988285d6c3c6003d7066f93a upstream, but drastically cut down for 2.6.27.y The bridge device always causes a warning because when it is first created it has the no checksum flag set along with all the segmentation/fragmentation offload bits. The code in register_netdevice incorrectly checks for only hardware checksum bit and ignores no checksum bit. Similar code is already in 2.6.28: commit b63365a2d60268a3988285d6c3c6003d7066f93a net: Fix disjunct computation of netdev features Signed-off-by: Stephen Hemminger Cc: David Miller Cc: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- diff --git a/net/core/dev.c b/net/core/dev.c index 0ae08d3f57e79..5a2589667c993 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3990,7 +3990,7 @@ int register_netdevice(struct net_device *dev) dev->features &= ~NETIF_F_TSO; } if (dev->features & NETIF_F_UFO) { - if (!(dev->features & NETIF_F_HW_CSUM)) { + if (!(dev->features & NETIF_F_GEN_CSUM)) { printk(KERN_ERR "%s: Dropping NETIF_F_UFO since no " "NETIF_F_HW_CSUM feature.\n", dev->name);