From: Łukasz Langa <lukasz@langa.pl>
Date: Sun, 9 Jan 2011 18:18:53 +0000 (+0000)
Subject: #10874: test_urllib2 shouldn't use `is` operator for comparing strings
X-Git-Tag: v3.2rc1~91
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d7e81cc5fa6a432a99dae06967823a0a3bf9a0e7;p=thirdparty%2FPython%2Fcpython.git

#10874: test_urllib2 shouldn't use `is` operator for comparing strings

Patch by Adreas Stührk.
---

diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py
index b8a609e4dcd2..17323d5da195 100644
--- a/Lib/test/test_urllib2.py
+++ b/Lib/test/test_urllib2.py
@@ -758,7 +758,7 @@ class HandlerTests(unittest.TestCase):
             else:
                 self.assertIs(o.req, req)
                 self.assertEqual(req.type, "ftp")
-            self.assertEqual(req.type is "ftp", ftp)
+            self.assertEqual(req.type == "ftp", ftp)
 
     def test_http(self):