From: Andrew Bartlett <abartlet@samba.org>
Date: Tue, 7 Aug 2012 11:29:53 +0000 (+1000)
Subject: s3-param: Remove never-reached condition for popts == NULL
X-Git-Tag: ldb-1.1.10~60
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d825adf86a91aa08588ef5fa95ce3f91abb9fd40;p=thirdparty%2Fsamba.git

s3-param: Remove never-reached condition for popts == NULL

All the callers provide a parametric options pointer to fill in.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Aug  7 17:16:38 CEST 2012 on sn-devel-104
---

diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index 6895ebe4d07..d4ee8a22f2b 100644
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -1495,10 +1495,6 @@ static void free_param_opts(struct parmlist_entry **popts)
 {
 	struct parmlist_entry *opt, *next_opt;
 
-	if (popts == NULL) {
-		return;
-	}
-
 	if (*popts != NULL) {
 		DEBUG(5, ("Freeing parametrics:\n"));
 	}