From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 22 Nov 2019 12:59:59 +0000 (+0100)
Subject: journald: why bitwise XOR when boolean != is easier to read?
X-Git-Tag: v245-rc1~41^2~48
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d83f7e4c9218fe409ff6b0269061f27fba1c1b79;p=thirdparty%2Fsystemd.git

journald: why bitwise XOR when boolean != is easier to read?
---

diff --git a/src/journal/journald-server.c b/src/journal/journald-server.c
index f6caf0e212a..305a5eff377 100644
--- a/src/journal/journald-server.c
+++ b/src/journal/journald-server.c
@@ -2043,7 +2043,7 @@ int server_init(Server *s) {
         if (r < 0)
                 log_warning_errno(r, "Failed to parse kernel command line, ignoring: %m");
 
-        if (!!s->ratelimit_interval ^ !!s->ratelimit_burst) {
+        if (!!s->ratelimit_interval != !!s->ratelimit_burst) { /* One set to 0 and the other not? */
                 log_debug("Setting both rate limit interval and burst from "USEC_FMT",%u to 0,0",
                           s->ratelimit_interval, s->ratelimit_burst);
                 s->ratelimit_interval = s->ratelimit_burst = 0;