From: Martin Schwenke <martin@meltin.net>
Date: Fri, 21 Jun 2019 04:41:38 +0000 (+1000)
Subject: ctdb-tests: Don't compare an unsigned value with -1
X-Git-Tag: samba-4.11.0rc1~52
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d855dc2a5faff1eafec287fa8748000d21949684;p=thirdparty%2Fsamba.git

ctdb-tests: Don't compare an unsigned value with -1

The dummy reader should never be called, so contains an assert on the
buffer length that should always trigger.  Just abort() instead.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
---

diff --git a/ctdb/tests/src/sock_io_test.c b/ctdb/tests/src/sock_io_test.c
index d0e424f5620..ba4b6377d6d 100644
--- a/ctdb/tests/src/sock_io_test.c
+++ b/ctdb/tests/src/sock_io_test.c
@@ -178,7 +178,7 @@ static void test2_reader(int fd)
 static void test2_dummy_reader(uint8_t *buf, size_t buflen,
 			       void *private_data)
 {
-	assert(buflen == -1);
+	abort();
 }
 
 static void test2_writer(struct sock_queue *queue)